← Back to team overview

ubuntu-webapps-bugs team mailing list archive

[Bug 1399201] [NEW] Test the sequence of LoadEvents for downloads

 

Public bug reported:

We have a could of simple tests for WebView.downloadRequested:

- Perform a top-level navigation where the main document response has "Content-Disposition: attachment", then verify the properties on the DownloadRequest.
- Perform a top-level navigation where the main document responds with an unhandled mime type, then verify the properties on the DownloadRequest.

However, there are some gaps in this:

- What are the sequence of LoadEvents? I honestly have no idea here, but we should be able to accurately document the expected behaviour of our API. I expect there's at least a "started" event, and it looks like there also has to be a "succeeded" event from the look of the way the test works. But is there a "committed" event?
- Unless I'm missing something, it looks like we don't have a test for <a> download attribute, but we should.

** Affects: oxide
     Importance: Medium
         Status: Triaged

** Changed in: oxide
       Status: New => Triaged

** Changed in: oxide
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Ubuntu
WebApps bug tracking, which is subscribed to Oxide.
https://bugs.launchpad.net/bugs/1399201

Title:
  Test the sequence of LoadEvents for downloads

Status in Oxide Webview:
  Triaged

Bug description:
  We have a could of simple tests for WebView.downloadRequested:

  - Perform a top-level navigation where the main document response has "Content-Disposition: attachment", then verify the properties on the DownloadRequest.
  - Perform a top-level navigation where the main document responds with an unhandled mime type, then verify the properties on the DownloadRequest.

  However, there are some gaps in this:

  - What are the sequence of LoadEvents? I honestly have no idea here, but we should be able to accurately document the expected behaviour of our API. I expect there's at least a "started" event, and it looks like there also has to be a "succeeded" event from the look of the way the test works. But is there a "committed" event?
  - Unless I'm missing something, it looks like we don't have a test for <a> download attribute, but we should.

To manage notifications about this bug go to:
https://bugs.launchpad.net/oxide/+bug/1399201/+subscriptions


Follow ups

References