ubuntu-webapps-bugs team mailing list archive

[Chris Coulson <chris.coulson@xxxxxxxxxxxxx>]

Public bug reported:

Currently when implementing virtual functions in derived classes, we
have a some functions annotated with the "override" keyword and some
annotated with the "final" keyword (and perhaps some using none). Also,
some are marked "virtual" and others aren't. This is something Google
have just tidied up in Chromium, and we should be consistent too:

Implementations of virtual functions in derived classes:
- don't need to be marked "virtual".
- should be annotated with "override" (ie, let's stop using "final").

** Affects: oxide
     Importance: Low
         Status: Triaged

** Changed in: oxide
   Importance: Undecided => Low

** Changed in: oxide
       Status: New => Triaged

-- 
You received this bug notification because you are a member of Ubuntu
WebApps bug tracking, which is subscribed to Oxide.
https://bugs.launchpad.net/bugs/1407337

Title:
  Implement virtual functions in derived classes consistently

Status in Oxide Webview:
  Triaged

Bug description:
  Currently when implementing virtual functions in derived classes, we
  have a some functions annotated with the "override" keyword and some
  annotated with the "final" keyword (and perhaps some using none).
  Also, some are marked "virtual" and others aren't. This is something
  Google have just tidied up in Chromium, and we should be consistent
  too:

  Implementations of virtual functions in derived classes:
  - don't need to be marked "virtual".
  - should be annotated with "override" (ie, let's stop using "final").

To manage notifications about this bug go to:
https://bugs.launchpad.net/oxide/+bug/1407337/+subscriptions