ubuntu-webapps-bugs team mailing list archive
-
ubuntu-webapps-bugs team
-
Mailing list archive
-
Message #02899
[Bug 1458963] [NEW] Favicons are saved to disk in private browsing mode
Public bug reported:
Currently, Oxide provides a http URL for the favicon via WebView.icon
and the browser uses this URL to download the image via Qt's network
stack. As well as displaying this in the addressbar, it also writes it
to disk.
There's a couple of problems here:
1) The favicon is written to disk even in private browsing mode.
2) I'm not too sure about this, but downloading using Qt's network stack potentially leaves a cache footprint. In any case, we don't audit its suitability for use with private browsing.
The first part will need to be fixed in the browser.
For the second part, I think that Oxide should do the actual network
transaction to fetch the favicon. We can provide an implementation of
QQmlImageProvider and make WebView.icon a image: URL. The browser should
still be able to use this URL to access and write the icons to disk (I
assume this is for displaying history), but it would do this by
requesting the QImage from Oxide's image provider, using
QQmlEngine::imageProvider() rather than doing the network transaction
itself.
** Affects: oxide
Importance: High
Status: Triaged
** Affects: webbrowser-app
Importance: High
Status: Confirmed
** Also affects: oxide
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Ubuntu
WebApps bug tracking, which is subscribed to webbrowser-app.
https://bugs.launchpad.net/bugs/1458963
Title:
Favicons are saved to disk in private browsing mode
Status in Oxide Webview:
Triaged
Status in Web Browser App:
Confirmed
Bug description:
Currently, Oxide provides a http URL for the favicon via WebView.icon
and the browser uses this URL to download the image via Qt's network
stack. As well as displaying this in the addressbar, it also writes it
to disk.
There's a couple of problems here:
1) The favicon is written to disk even in private browsing mode.
2) I'm not too sure about this, but downloading using Qt's network stack potentially leaves a cache footprint. In any case, we don't audit its suitability for use with private browsing.
The first part will need to be fixed in the browser.
For the second part, I think that Oxide should do the actual network
transaction to fetch the favicon. We can provide an implementation of
QQmlImageProvider and make WebView.icon a image: URL. The browser
should still be able to use this URL to access and write the icons to
disk (I assume this is for displaying history), but it would do this
by requesting the QImage from Oxide's image provider, using
QQmlEngine::imageProvider() rather than doing the network transaction
itself.
To manage notifications about this bug go to:
https://bugs.launchpad.net/oxide/+bug/1458963/+subscriptions
Follow ups
References