ubuntu-webapps-bugs team mailing list archive

[Chris Coulson <chrisccoulson@xxxxxxxxxx>]

Public bug reported:

The log level transmitted through Oxide isn't strongly typed, and it's
cast to LogMessageSecurityLevel in OxideQQuickWebView. At some point,
the logging levels have changed which breaks this cast.

The cast currently works like this:

 -1 (logging::LOG_VERBOSE) -> LogSeverityVerbose
 0 (logging::LOG_INFO) -> LogSeverityInfo
 1 (logging::LOG_WARNING) -> LogSeverityWarning
 2 (logging::LOG_ERROR) -> LogSeverityError
 3 (logging::LOG_FATAL) -> LogSeverityErrorReport

No valid logging level casts to LogSeverityFatal.

This cast is unsafe anyway - we should only ever be casting like this if
we have appropriate static_asserts to catch breakage like this.

Obviously, LogSeverityErrorReport is obsolete and unused. But it turns
out that LogSeverityFatal is unused too (blink can't log fatal errors -
those are a result of DCHECKs).

** Affects: oxide
     Importance: High
         Status: Triaged

** Changed in: oxide
   Importance: Undecided => High

** Changed in: oxide
       Status: New => Triaged

-- 
You received this bug notification because you are a member of Ubuntu
WebApps bug tracking, which is subscribed to Oxide.
https://bugs.launchpad.net/bugs/1624003

Title:
  WebView::LogMessageSecurityLevel cast is broken

Status in Oxide:
  Triaged

Bug description:
  The log level transmitted through Oxide isn't strongly typed, and it's
  cast to LogMessageSecurityLevel in OxideQQuickWebView. At some point,
  the logging levels have changed which breaks this cast.

  The cast currently works like this:

   -1 (logging::LOG_VERBOSE) -> LogSeverityVerbose
   0 (logging::LOG_INFO) -> LogSeverityInfo
   1 (logging::LOG_WARNING) -> LogSeverityWarning
   2 (logging::LOG_ERROR) -> LogSeverityError
   3 (logging::LOG_FATAL) -> LogSeverityErrorReport

  No valid logging level casts to LogSeverityFatal.

  This cast is unsafe anyway - we should only ever be casting like this
  if we have appropriate static_asserts to catch breakage like this.

  Obviously, LogSeverityErrorReport is obsolete and unused. But it turns
  out that LogSeverityFatal is unused too (blink can't log fatal errors
  - those are a result of DCHECKs).

To manage notifications about this bug go to:
https://bugs.launchpad.net/oxide/+bug/1624003/+subscriptions