← Back to team overview

unity-dev team mailing list archive

Re: Heads up on lp:compiz

 

Yes this happened last year (on 9th Feb too). And we immediately locked down the branch to prevent direct pushes from being able to overwrite previous revisions.

However, that was lp:compiz-core and the same protection was probably not applied when we switched to lp:compiz later in the year.

It's not direct push access that's a problem. We just need to lock out any pushes that change history (overwrite previous revisions). Tim has a little script for adding the protection to any branch.

- Daniel


On 10/02/13 15:59, Sam Spilsbury wrote:
Okay, an update on this.

Thankfully, the automatic upload to distro saved the day on this one,
because I was able to use the latest snapshot by jenkins and restore
lp:compiz to r3602. The downside is that the trunk r3602 is not going
to be the same as trunk r3602 about 3 hours ago, so if you have
something that is pulling from lp:compiz, and had r3602 before this
mess happened, then those branches histories will diverge. Also, check
to see if you had anything merged in the past day to make sure it did
not go in after r3602.

I am pretty sure there was only one branch that went in after r3602,
and it was one of mine, which I've now marked as backed out.

However, I can unfortunately confirm that I do indeed have direct push
access AND overwrite access to lp:compiz, as does everyone else in
~compiz-team. That's really bad, because all it takes is one
misconfigured branch and you can unintentionally nuke trunk. I thought
that when we switched to using merge bots that all went away?

Is there anything we can do about this?

Again I profusely apologize, and I hope I've done the best thing I
could have to rectify this situation.

Cheers,

Sam

On Sun, Feb 10, 2013 at 3:08 PM, Sam Spilsbury <smspillaz@xxxxxxxxx> wrote:
Hey Guys,

I have some bad news. I was pushing some branches and somehow managed
to overwrite lp:compiz with one of my own branches. I am looking into
the best way to restore that ASAP.

I don't even know how that happened, because as far as I know, nobody
has direct write access to the trunks, and bzr would have warned me if
it was going to overwrite something. In addition, I never push stuff
directly to lp:compiz.

Hopefully it will be fixed up by the time you all get back to work.

Really sorry about that.

Sam



--
Sam Spilsbury





Follow ups

References