← Back to team overview

unity-dev team mailing list archive

Re: Bug #1154364

 

I ll take a look on Tuesday. Thanks
On 6 Nov 2015 11:19 am, "Prasad Somwanshi" <prasad.s@xxxxxxxx> wrote:

> I realized that, it need to contributed with a branch. Do I need to do it
> ? Or shall do it after initial feedback.
>
>
>
> Sent: Wednesday, November 04, 2015 at 11:16 PM
> From: "Prasad Somwanshi" <prasad.s@xxxxxxxx>
> To: "Marco Trevisan" <marco.trevisan@xxxxxxxxxxxxx>
> Cc: unity-dev@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Unity-dev] Bug #1154364
> Find attached patch for this fix. Let me know what you think about it.My
> feeling is , it could do with initial time out value of between 250 ms and
> 500 ms. So that a meaningful query can be formed, before actually searching
> it. Haven't touched SearchBar::ForceLiveSearch.
>
>
>
> Sent: Wednesday, November 04, 2015 at 2:44 PM
> From: "Marco Trevisan" <marco.trevisan@xxxxxxxxxxxxx>
> To: "Prasad Somwanshi" <prasad.s@xxxxxxxx>, unity-dev@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Unity-dev] Bug #1154364
> Il 04/11/2015 15:38, Prasad Somwanshi ha scritto:
> > Marco,
> >
> > Right now, there is pause of 40 ms , which is reset after each
> keystroke. To check is user is still typing in.
> > My suggestion is a bit different.
> > Depending on no of characters in search box, it should wait decresing no
> of ms before doing actual search.
> >
> > If user presses 'P', it's single character, so wait for 500 ms(or 250
> ms), and there are more chances of use typing in more characters.
> > Then user presses 'r'. We have 2 characters.(then wait for 250 ms(or 125
> ms). Keep on reducing wait time as no of characters grows, and keep
> existing 40 ms as floor .
> > So user may be able to do actual search 'prasad', without having to do
> search 'p' or 'pr' or 'pra'.
> > So it will avoid effect of displaying result for non intended search
> words.
>
> The idea it's not bad...
> Maybe 500ms as starting point is too much, as sometimes I'd just want to
> type "f", firefox spots and I hit enter, but we could indeed increase
> this wait so that it's slower and then gets quicker.
>
> If you want to contribute with a branch, it would be cool to review it.
>
> Thanks
>  --
> Mailing list: https://launchpad.net/~unity-dev
> Post to : unity-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe :
> https://launchpad.net/~unity-dev[https://launchpad.net/~unity-dev]
> More help :
> https://help.launchpad.net/ListHelp[https://help.launchpad.net/ListHelp]
>
> --
> Mailing list: https://launchpad.net/~unity-dev
> Post to     : unity-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~unity-dev
> More help   : https://help.launchpad.net/ListHelp
>

Follow ups

References