widelands-dev team mailing list archive

[Nicolai Hähnle <prefect_@xxxxxxx>]

Hmm. It still seems somehow "not bold enough". The overhead of shared_ptrs wouldn't really matter, and we'd be safer down the line. I realize you wanted to just do some quick fixes (and they do look fine to me - so before we let this branch rot, we should just go ahead and merge it, after all, the perfect is the enemy of the good), but why not just go to the root while we're at it? It does seem to be the right thing to do, at least to me.
-- 
https://code.launchpad.net/~csirkeee/widelands/memory-leaks-2/+merge/150290
Your team Widelands Developers is requested to review the proposed merge of lp:~csirkeee/widelands/memory-leaks-2 into lp:widelands.