widelands-dev team mailing list archive
-
widelands-dev team
-
Mailing list archive
-
Message #01301
Re: [Merge] lp:~widelands-dev/widelands/bug657285 into lp:widelands
A few comments concerning the opengl stuff:
- When an empty string, such as "<rt><font=SansSherif></font></rt>" is to be rendered using an opengl surface, a segfault occured. The solution implemented here prevents any gl call if width or height is <=0. The surface will still be created and cached.
- The repetition occured because the blit function scaled the texture space coord but still draw the whole rect passed in. I corrected that by ensuring the clipping rect is no larger than the texture in the Graphics blitrect function.
- I did experience the white backgrounds behaviour at some point during testing, but it seems that with these two fixes the problem is gone.
--
https://code.launchpad.net/~widelands-dev/widelands/bug657285/+merge/175551
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug657285.
References