← Back to team overview

widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~hjd/widelands/cppcheck-issues into lp:widelands

To: mp+198154@xxxxxxxxxxxxxxxxxx
From: SirVer <SirVer@xxxxxx>
Date: Mon, 16 Dec 2013 09:19:25 -0000
In-reply-to: <20131207134727.31730.53462.launchpad@ackee.canonical.com>
Reply-to: mp+198154@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Not all of these are uncritical, i.e. std::string name = r.String(); will read bytes from r., removing the variable is fine, but the r.String(); must remain (with a comment).

-- 
https://code.launchpad.net/~hjd/widelands/cppcheck-issues/+merge/198154
Your team Widelands Developers is requested to review the proposed merge of lp:~hjd/widelands/cppcheck-issues into lp:widelands.

References

[Merge] lp:~hjd/widelands/cppcheck-issues into lp:widelands
From: Hans Joachim Desserud, 2013-12-07