widelands-dev team mailing list archive

[Hans Joachim Desserud <launchpad@xxxxxxxxxxxx>]

>Not sure if this is accurate. Boost signals2 is required to build widelands, but it is headers only - i.e. it does not need to be linked in.

Well, for some reason I failed to write down the longer explanation, so that's understandable. :)

At first I was confused when I saw it was removed from the cmake config, because I thought that was how it verified the headers was present. Which made me wonder how the packages were split and whether the needed parts resided somewhere common. So I did the following on my Debian Unstable system:
While still on 6820, removed the libboost-signals packages.
Verified WL failed to build from source (due to the check still present in cmake).
Bzr pulled to 6821.
Built from source and ran the game, which worked without any problems.

So from what I can see, the specific signals packages doesn't seem to be required anymore. The content of the packages seem to confirm this too:

$ dpkg -L libboost-signals1.53-dev 
/.
/usr
/usr/lib
/usr/lib/x86_64-linux-gnu
/usr/lib/x86_64-linux-gnu/libboost_signals.a
/usr/share
/usr/share/doc
/usr/share/doc/libboost-signals1.53-dev
/usr/share/doc/libboost-signals1.53-dev/copyright
/usr/lib/x86_64-linux-gnu/libboost_signals.so
/usr/share/doc/libboost-signals1.53-dev/changelog.Debian.gz


$ dpkg -L libboost1.53-dev | grep signals2
/usr/include/boost/signals2.hpp
/usr/include/boost/signals2
/usr/include/boost/signals2/variadic_signal.hpp
/usr/include/boost/signals2/shared_connection_block.hpp
/usr/include/boost/signals2/detail
/usr/include/boost/signals2/detail/null_output_iterator.hpp
/usr/include/boost/signals2/detail/variadic_arg_type.hpp
/usr/include/boost/signals2/detail/lwm_nop.hpp
/usr/include/boost/signals2/detail/slot_template.hpp
/usr/include/boost/signals2/detail/tracked_objects_visitor.hpp
/usr/include/boost/signals2/detail/auto_buffer.hpp
/usr/include/boost/signals2/detail/variadic_slot_invoker.hpp
/usr/include/boost/signals2/detail/signals_common.hpp
/usr/include/boost/signals2/detail/lwm_pthreads.hpp
/usr/include/boost/signals2/detail/foreign_ptr.hpp
/usr/include/boost/signals2/detail/preprocessed_arg_type.hpp
/usr/include/boost/signals2/detail/preprocessed_arg_type_template.hpp
/usr/include/boost/signals2/detail/slot_groups.hpp
/usr/include/boost/signals2/detail/signal_template.hpp
/usr/include/boost/signals2/detail/replace_slot_function.hpp
/usr/include/boost/signals2/detail/result_type_wrapper.hpp
/usr/include/boost/signals2/detail/signals_common_macros.hpp
/usr/include/boost/signals2/detail/slot_call_iterator.hpp
/usr/include/boost/signals2/detail/unique_lock.hpp
/usr/include/boost/signals2/detail/lwm_win32_cs.hpp
/usr/include/boost/signals2/deconstruct_ptr.hpp
/usr/include/boost/signals2/signal_type.hpp
/usr/include/boost/signals2/deconstruct.hpp
/usr/include/boost/signals2/slot_base.hpp
/usr/include/boost/signals2/variadic_slot.hpp
/usr/include/boost/signals2/predestructible.hpp
/usr/include/boost/signals2/expired_slot.hpp
/usr/include/boost/signals2/preprocessed_signal.hpp
/usr/include/boost/signals2/preprocessed_slot.hpp
/usr/include/boost/signals2/signal_base.hpp
/usr/include/boost/signals2/trackable.hpp
/usr/include/boost/signals2/slot.hpp
/usr/include/boost/signals2/mutex.hpp
/usr/include/boost/signals2/optional_last_value.hpp
/usr/include/boost/signals2/dummy_mutex.hpp
/usr/include/boost/signals2/signal.hpp
/usr/include/boost/signals2/connection.hpp
/usr/include/boost/signals2/postconstructible.hpp
/usr/include/boost/signals2/last_value.hpp

What I haven't done, and which we may want to consider is to take this for a test spin when building the PPA packages. (For instance, I haven't verified whether this is also true for older boost packages.) I'm not sure if we want to do this on the official PPA (though should be easy to revert in case something doesn't work right), or if I should set up a separate PPA for testing the packaging. (I might do the latter at some point anyways, but I haven't looked much into it yet..)
-- 
https://code.launchpad.net/~hjd/widelands/debian-remove-boost-signals/+merge/200734
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/debian.