widelands-dev team mailing list archive

Thread
Date

[Merge] lp:~qcumber-some/widelands/cmake-unclutter into lp:widelands

To: mp+226602@xxxxxxxxxxxxxxxxxx
From: Jens Beyer <Qcumber-some@xxxxxxxxxxxxx>
Date: Sun, 13 Jul 2014 09:21:26 -0000
Reply-to: mp+226602@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Jens Beyer has proposed merging lp:~qcumber-some/widelands/cmake-unclutter into lp:widelands.

Requested reviews:
  Widelands Developers (widelands-dev)

For more details, see:
https://code.launchpad.net/~qcumber-some/widelands/cmake-unclutter/+merge/226602

Leaving this here for your judgement.

In my eyes it looks less cluttered when the function and macro definitions are moved outside.
Relevant workflow is easier to see. Detail implementations are one click away though. Guess that's kind of personal preference.

I don't mind if you vote against this. Just giving it a try ;-)
-- 
https://code.launchpad.net/~qcumber-some/widelands/cmake-unclutter/+merge/226602
Your team Widelands Developers is requested to review the proposed merge of lp:~qcumber-some/widelands/cmake-unclutter into lp:widelands.

=== modified file 'CMakeLists.txt'
--- CMakeLists.txt	2014-07-08 04:23:00 +0000
+++ CMakeLists.txt	2014-07-13 09:20:42 +0000
@@ -2,18 +2,12 @@
 
 cmake_minimum_required (VERSION 2.8.7)
 
+include("${CMAKE_SOURCE_DIR}/cmake/WlFunctions.cmake")
+
 if (CMAKE_SOURCE_DIR STREQUAL CMAKE_BINARY_DIR)
   message(FATAL_ERROR "Build directory and source directory must not be the same.")
 endif (CMAKE_SOURCE_DIR STREQUAL CMAKE_BINARY_DIR)
 
-# Define the directory structure for installation - will be hardcoded in WL bin
-# (through config.h).
-macro(_set_if_unset VAR VALUE)
-  if (NOT ${VAR} OR ${VAR} STREQUAL "")
-	  set (${VAR} ${VALUE})
-  endif()
-endmacro(_set_if_unset)
-
 if(WIN32 OR APPLE OR WL_PORTABLE)
   _set_if_unset(WL_INSTALL_PREFIX ".")
   _set_if_unset(WL_INSTALL_DATADIR ".")
@@ -97,15 +91,6 @@
   message(FATAL_ERROR "Unknown CMAKE_BUILD_TYPE: ${CMAKE_BUILD_TYPE}")
 endif()
 
-
-function(add_flag VAR_NAME FLAG)
-  if (${VAR_NAME})
-    set(${VAR_NAME} "${${VAR_NAME}} ${FLAG}" PARENT_SCOPE)
-  else()
-    set(${VAR_NAME} "${FLAG}" PARENT_SCOPE)
-  endif()
-endfunction()
-
 add_flag(WL_GENERIC_CXX_FLAGS "-std=c++11")
 
 if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")

=== added file 'cmake/WlFunctions.cmake'
--- cmake/WlFunctions.cmake	1970-01-01 00:00:00 +0000
+++ cmake/WlFunctions.cmake	2014-07-13 09:20:42 +0000
@@ -0,0 +1,247 @@
+macro(_parse_common_args ARGS)
+  set(OPTIONS
+    THIRD_PARTY  # Is a third party lib. Less warnings, no codecheck.
+    C_LIBRARY # Pure C library. No CXX flags.
+    WIN32 # Windows binary/library.
+    USES_BOOST_REGEX
+    USES_INTL
+    USES_OPENGL
+    USES_PNG
+    USES_SDL
+    USES_SDL_GFX
+    USES_SDL_IMAGE
+    USES_SDL_MIXER
+    USES_SDL_NET
+    USES_SDL_TTF
+    USES_ZLIB
+  )
+  set(ONE_VALUE_ARG )
+  set(MULTI_VALUE_ARGS SRCS DEPENDS)
+  cmake_parse_arguments(ARG "${OPTIONS}" "${ONE_VALUE_ARG}" "${MULTI_VALUE_ARGS}"
+    ${ARGS}
+  )
+endmacro(_parse_common_args)
+
+# Define the directory structure for installation - will be hardcoded in WL bin
+# (through config.h).
+macro(_set_if_unset VAR VALUE)
+  if (NOT ${VAR} OR ${VAR} STREQUAL "")
+	  set (${VAR} ${VALUE})
+  endif()
+endmacro(_set_if_unset)
+
+function(_include_directories TARGET DIR)
+  _include_directories_internal(${TARGET} ${DIR} FALSE)
+endfunction(_include_directories TARGET DIR)
+function(_include_system_directories TARGET DIR)
+  _include_directories_internal(${TARGET} ${DIR} TRUE)
+endfunction(_include_system_directories TARGET_DIR)
+
+macro(_common_compile_tasks)
+  if (NOT ARG_C_LIBRARY)
+    set(TARGET_COMPILE_FLAGS "${TARGET_COMPILE_FLAGS} ${WL_GENERIC_CXX_FLAGS}")
+
+    # This is needed for header only libraries. While they do not really mean
+    # anything for cmake, they are useful to make dependencies explicit.
+    set_target_properties(${NAME} PROPERTIES LINKER_LANGUAGE CXX)
+  endif()
+
+  set(TARGET_COMPILE_FLAGS "${TARGET_COMPILE_FLAGS} ${WL_OPTIMIZE_FLAGS} ${WL_DEBUG_FLAGS}")
+
+  if(ARG_THIRD_PARTY)
+    # Disable all warings for third_party.
+    set(TARGET_COMPILE_FLAGS "${TARGET_COMPILE_FLAGS} -w")
+  else()
+    foreach(SRC ${ARG_SRCS})
+      run_codecheck(${NAME} ${SRC})
+    endforeach(SRC)
+
+    set(TARGET_COMPILE_FLAGS "${TARGET_COMPILE_FLAGS} ${WL_COMPILE_DIAGNOSTICS}")
+  endif()
+
+  set_target_properties(${NAME} PROPERTIES COMPILE_FLAGS ${TARGET_COMPILE_FLAGS})
+
+  if(NOT ARG_THIRD_PARTY)
+    # src/ is the base for all of our includes. The binary one is for generated files.
+    _include_directories(${NAME} ${CMAKE_SOURCE_DIR}/src)
+    _include_directories(${NAME} ${CMAKE_BINARY_DIR}/src)
+
+    # Boost is practically the standard library, so we always add a search path
+    # to include it easily. Except for third party.
+    _include_system_directories(${NAME} ${Boost_INCLUDE_DIR})
+  endif()
+
+  if(ARG_USES_ZLIB)
+    _include_system_directories(${NAME} ${ZLIB_INCLUDE_DIRS})
+    target_link_libraries(${NAME} ${ZLIB_LIBRARY})
+  endif()
+
+  # OpenGL and GLEW are one thing for us. If you use the one, you also use the
+  # other.
+  if(ARG_USES_OPENGL)
+    _include_system_directories(${NAME} ${GLEW_INCLUDE_DIR})
+    target_link_libraries(${NAME} ${GLEW_LIBRARY})
+    target_link_libraries(${NAME} ${OPENGL_gl_LIBRARY})
+    add_definitions(${GLEW_EXTRA_DEFINITIONS})
+  endif()
+
+  if(ARG_USES_PNG)
+    _include_system_directories(${NAME} ${PNG_INCLUDE_DIR})
+    target_link_libraries(${NAME} ${PNG_LIBRARY})
+  endif()
+
+  if(ARG_USES_SDL)
+    _include_system_directories(${NAME} ${SDL_INCLUDE_DIR})
+    target_link_libraries(${NAME} ${SDL_LIBRARY})
+  endif()
+
+  if(ARG_USES_SDL_MIXER)
+    _include_system_directories(${NAME} ${SDLMIXER_INCLUDE_DIR})
+    target_link_libraries(${NAME} ${SDLMIXER_LIBRARY})
+  endif()
+
+  if(ARG_USES_SDL_NET)
+    _include_system_directories(${NAME} ${SDLNET_INCLUDE_DIR})
+    target_link_libraries(${NAME} ${SDLNET_LIBRARY})
+  endif()
+
+  if(ARG_USES_SDL_IMAGE)
+    _include_system_directories(${NAME} ${SDLIMAGE_INCLUDE_DIR})
+    target_link_libraries(${NAME} ${SDLIMAGE_LIBRARY})
+  endif()
+
+  if(ARG_USES_SDL_GFX)
+    _include_system_directories(${NAME} ${SDLGFX_INCLUDE_DIR})
+    target_link_libraries(${NAME} ${SDLGFX_LIBRARY})
+  endif()
+
+  if(ARG_USES_SDL_TTF)
+    _include_system_directories(${NAME} ${SDLTTF_INCLUDE_DIR})
+    target_link_libraries(${NAME} ${SDLTTF_LIBRARY})
+  endif()
+
+  if (ARG_USES_INTL)
+    # libintl is not used on all systems, so only include it, when we actually
+    # found it.
+    if (INTL_FOUND)
+      _include_system_directories(${NAME} ${INTL_INCLUDE_DIR})
+      target_link_libraries(${NAME} ${INTL_LIBRARY})
+    endif()
+  endif()
+
+  if (ARG_USES_BOOST_REGEX)
+    target_link_libraries(${NAME} ${Boost_LIBRARIES})
+  endif()
+
+  foreach(DEPENDENCY ${ARG_DEPENDS})
+    target_link_libraries(${NAME} ${DEPENDENCY})
+  endforeach(DEPENDENCY)
+endmacro(_common_compile_tasks)
+
+# See
+# http://www.cmake.org/cmake/help/v3.0/module/CMakeParseArguments.html
+function(wl_library NAME)
+  _parse_common_args("${ARGN}")
+
+  add_library(${NAME}
+    STATIC
+    EXCLUDE_FROM_ALL
+    ${ARG_SRCS}
+  )
+
+  # increase the tries for the linker searching for cyclic dependencies
+  # TODO remove this once cycling dependencies are history in widelands
+  set_target_properties(${NAME} PROPERTIES LINK_INTERFACE_MULTIPLICITY 5)
+
+  _common_compile_tasks()
+endfunction()
+
+function(wl_test NAME)
+  _parse_common_args("${ARGN}")
+
+  add_executable(${NAME} ${ARG_SRCS})
+
+  # If boost unit test library is linked dynamically, BOOST_TEST_DYN_LINK must be defined
+  string(REGEX MATCH ".a$" BOOST_STATIC_UNIT_TEST_LIB ${Boost_UNIT_TEST_FRAMEWORK_LIBRARY})
+  if (NOT BOOST_STATIC_UNIT_TEST_LIB)
+    set(TARGET_COMPILE_FLAGS "${TARGET_COMPILE_FLAGS} -DBOOST_TEST_DYN_LINK")
+  endif()
+  target_link_libraries(${NAME} ${Boost_UNIT_TEST_FRAMEWORK_LIBRARY})
+
+  # Tests need to link with SDL library without main.
+  set(SDL_LIBRARY_TEMP ${SDL_LIBRARY})
+  list(REMOVE_ITEM SDL_LIBRARY_TEMP ${SDLMAIN_LIBRARY})
+  target_link_libraries(${NAME} ${SDL_LIBRARY_TEMP})
+
+  _common_compile_tasks()
+
+  add_test(${NAME} ${NAME})
+  add_dependencies(wl_tests ${NAME})
+endfunction()
+
+# Checks a single 'SRC' file using Codecheck and writes a file named
+# codecheck_<shasum of input> if the codecheck did not yield anything. The
+# target for the codecheck will be added as a dependency to 'NAME' for debug
+# builds, but always for the target 'codecheck', so that make codecheck checks
+# all source code.
+function(run_codecheck NAME SRC)
+  get_filename_component(ABSOLUTE_SRC ${SRC} ABSOLUTE)
+
+  # If the file does not exist, it is probably auto-generated. In that case, it
+  # makes no sense to codecheck it.
+  if(EXISTS ${ABSOLUTE_SRC})
+    string(SHA1 CHECKSUM ${ABSOLUTE_SRC})
+
+    set(OUTPUT_FILE "${CMAKE_CURRENT_BINARY_DIR}/codecheck_${CHECKSUM}")
+    add_custom_command(
+      OUTPUT
+        ${OUTPUT_FILE}
+      COMMAND
+        ${CMAKE_COMMAND}
+        -DPYTHON_EXECUTABLE=${PYTHON_EXECUTABLE}
+        -DWL_SOURCE_CHECKER=${CMAKE_SOURCE_DIR}/cmake/codecheck/CodeCheck.py
+        -DSRC=${ABSOLUTE_SRC}
+        -DOUTPUT_FILE=${OUTPUT_FILE}
+        -DCMAKE_CURRENT_BINARY_DIR=${CMAKE_CURRENT_BINARY_DIR}
+        -P ${CMAKE_SOURCE_DIR}/cmake/codecheck/CodeCheck.cmake
+      DEPENDS ${ABSOLUTE_SRC}
+      COMMENT "Checking ${SRC} with CodeCheck"
+    )
+    add_custom_target(
+      see_if_codecheck_needs_to_run_${CHECKSUM}
+      DEPENDS ${OUTPUT_FILE}
+      COMMENT ""
+    )
+
+    add_dependencies(codecheck see_if_codecheck_needs_to_run_${CHECKSUM})
+
+    if(CMAKE_BUILD_TYPE STREQUAL Debug)
+      add_dependencies(${NAME} see_if_codecheck_needs_to_run_${CHECKSUM})
+    endif(CMAKE_BUILD_TYPE STREQUAL Debug)
+  endif(EXISTS ${ABSOLUTE_SRC})
+endfunction(run_codecheck)
+
+function(add_flag VAR_NAME FLAG)
+  if (${VAR_NAME})
+    set(${VAR_NAME} "${${VAR_NAME}} ${FLAG}" PARENT_SCOPE)
+  else()
+    set(${VAR_NAME} "${FLAG}" PARENT_SCOPE)
+  endif()
+endfunction()
+
+function(wl_binary NAME)
+  _parse_common_args("${ARGN}")
+
+  if (ARG_WIN32)
+    add_executable(${NAME}
+      WIN32
+      ${ARG_SRCS}
+    )
+  else()
+    add_executable(${NAME}
+      ${ARG_SRCS}
+    )
+  endif()
+
+  _common_compile_tasks()
+endfunction()

=== modified file 'src/CMakeLists.txt'
--- src/CMakeLists.txt	2014-07-05 19:33:23 +0000
+++ src/CMakeLists.txt	2014-07-13 09:20:42 +0000
@@ -16,30 +16,6 @@
 # http://stackoverflow.com/questions/733475/cmake-ctest-make-test-doesnt-build-tests
 add_custom_target(wl_tests)
 
-macro(_parse_common_args ARGS)
-  set(OPTIONS
-    THIRD_PARTY  # Is a third party lib. Less warnings, no codecheck.
-    C_LIBRARY # Pure C library. No CXX flags.
-    WIN32 # Windows binary/library.
-    USES_BOOST_REGEX
-    USES_INTL
-    USES_OPENGL
-    USES_PNG
-    USES_SDL
-    USES_SDL_GFX
-    USES_SDL_IMAGE
-    USES_SDL_MIXER
-    USES_SDL_NET
-    USES_SDL_TTF
-    USES_ZLIB
-  )
-  set(ONE_VALUE_ARG )
-  set(MULTI_VALUE_ARGS SRCS DEPENDS)
-  cmake_parse_arguments(ARG "${OPTIONS}" "${ONE_VALUE_ARG}" "${MULTI_VALUE_ARGS}"
-    ${ARGS}
-  )
-endmacro(_parse_common_args)
-
 #include the cmake version dependend macro _include_directories
 if (CMAKE_VERSION VERSION_LESS 2.8.11)
   include (${CMAKE_SOURCE_DIR}/cmake/IncludeDirectoriesOld.cmake)
@@ -47,214 +23,6 @@
   include (${CMAKE_SOURCE_DIR}/cmake/IncludeDirectories.cmake)
 endif (CMAKE_VERSION VERSION_LESS 2.8.11)
 
-function(_include_directories TARGET DIR)
-  _include_directories_internal(${TARGET} ${DIR} FALSE)
-endfunction(_include_directories TARGET DIR)
-function(_include_system_directories TARGET DIR)
-  _include_directories_internal(${TARGET} ${DIR} TRUE)
-endfunction(_include_system_directories TARGET_DIR)
-
-macro(_common_compile_tasks)
-  if (NOT ARG_C_LIBRARY)
-    set(TARGET_COMPILE_FLAGS "${TARGET_COMPILE_FLAGS} ${WL_GENERIC_CXX_FLAGS}")
-
-    # This is needed for header only libraries. While they do not really mean
-    # anything for cmake, they are useful to make dependencies explicit.
-    set_target_properties(${NAME} PROPERTIES LINKER_LANGUAGE CXX)
-  endif()
-
-  set(TARGET_COMPILE_FLAGS "${TARGET_COMPILE_FLAGS} ${WL_OPTIMIZE_FLAGS} ${WL_DEBUG_FLAGS}")
-
-  if(ARG_THIRD_PARTY)
-    # Disable all warings for third_party.
-    set(TARGET_COMPILE_FLAGS "${TARGET_COMPILE_FLAGS} -w")
-  else()
-    foreach(SRC ${ARG_SRCS})
-      run_codecheck(${NAME} ${SRC})
-    endforeach(SRC)
-
-    set(TARGET_COMPILE_FLAGS "${TARGET_COMPILE_FLAGS} ${WL_COMPILE_DIAGNOSTICS}")
-  endif()
-
-  set_target_properties(${NAME} PROPERTIES COMPILE_FLAGS ${TARGET_COMPILE_FLAGS})
-
-  if(NOT ARG_THIRD_PARTY)
-    # src/ is the base for all of our includes. The binary one is for generated files.
-    _include_directories(${NAME} ${CMAKE_SOURCE_DIR}/src)
-    _include_directories(${NAME} ${CMAKE_BINARY_DIR}/src)
-
-    # Boost is practically the standard library, so we always add a search path
-    # to include it easily. Except for third party.
-    _include_system_directories(${NAME} ${Boost_INCLUDE_DIR})
-  endif()
-
-  if(ARG_USES_ZLIB)
-    _include_system_directories(${NAME} ${ZLIB_INCLUDE_DIRS})
-    target_link_libraries(${NAME} ${ZLIB_LIBRARY})
-  endif()
-
-  # OpenGL and GLEW are one thing for us. If you use the one, you also use the
-  # other.
-  if(ARG_USES_OPENGL)
-    _include_system_directories(${NAME} ${GLEW_INCLUDE_DIR})
-    target_link_libraries(${NAME} ${GLEW_LIBRARY})
-    target_link_libraries(${NAME} ${OPENGL_gl_LIBRARY})
-    add_definitions(${GLEW_EXTRA_DEFINITIONS})
-  endif()
-
-  if(ARG_USES_PNG)
-    _include_system_directories(${NAME} ${PNG_INCLUDE_DIR})
-    target_link_libraries(${NAME} ${PNG_LIBRARY})
-  endif()
-
-  if(ARG_USES_SDL)
-    _include_system_directories(${NAME} ${SDL_INCLUDE_DIR})
-    target_link_libraries(${NAME} ${SDL_LIBRARY})
-  endif()
-
-  if(ARG_USES_SDL_MIXER)
-    _include_system_directories(${NAME} ${SDLMIXER_INCLUDE_DIR})
-    target_link_libraries(${NAME} ${SDLMIXER_LIBRARY})
-  endif()
-
-  if(ARG_USES_SDL_NET)
-    _include_system_directories(${NAME} ${SDLNET_INCLUDE_DIR})
-    target_link_libraries(${NAME} ${SDLNET_LIBRARY})
-  endif()
-
-  if(ARG_USES_SDL_IMAGE)
-    _include_system_directories(${NAME} ${SDLIMAGE_INCLUDE_DIR})
-    target_link_libraries(${NAME} ${SDLIMAGE_LIBRARY})
-  endif()
-
-  if(ARG_USES_SDL_GFX)
-    _include_system_directories(${NAME} ${SDLGFX_INCLUDE_DIR})
-    target_link_libraries(${NAME} ${SDLGFX_LIBRARY})
-  endif()
-
-  if(ARG_USES_SDL_TTF)
-    _include_system_directories(${NAME} ${SDLTTF_INCLUDE_DIR})
-    target_link_libraries(${NAME} ${SDLTTF_LIBRARY})
-  endif()
-
-  if (ARG_USES_INTL)
-    # libintl is not used on all systems, so only include it, when we actually
-    # found it.
-    if (INTL_FOUND)
-      _include_system_directories(${NAME} ${INTL_INCLUDE_DIR})
-      target_link_libraries(${NAME} ${INTL_LIBRARY})
-    endif()
-  endif()
-
-  if (ARG_USES_BOOST_REGEX)
-    target_link_libraries(${NAME} ${Boost_LIBRARIES})
-  endif()
-
-  foreach(DEPENDENCY ${ARG_DEPENDS})
-    target_link_libraries(${NAME} ${DEPENDENCY})
-  endforeach(DEPENDENCY)
-endmacro(_common_compile_tasks)
-
-# See
-# http://www.cmake.org/cmake/help/v3.0/module/CMakeParseArguments.html
-function(wl_library NAME)
-  _parse_common_args("${ARGN}")
-
-  add_library(${NAME}
-    STATIC
-    EXCLUDE_FROM_ALL
-    ${ARG_SRCS}
-  )
-
-  # increase the tries for the linker searching for cyclic dependencies
-  # TODO remove this once cycling dependencies are history in widelands
-  set_target_properties(${NAME} PROPERTIES LINK_INTERFACE_MULTIPLICITY 5)
-
-  _common_compile_tasks()
-endfunction()
-
-function(wl_binary NAME)
-  _parse_common_args("${ARGN}")
-
-  if (ARG_WIN32)
-    add_executable(${NAME}
-      WIN32
-      ${ARG_SRCS}
-    )
-  else()
-    add_executable(${NAME}
-      ${ARG_SRCS}
-    )
-  endif()
-
-  _common_compile_tasks()
-endfunction()
-
-function(wl_test NAME)
-  _parse_common_args("${ARGN}")
-
-  add_executable(${NAME} ${ARG_SRCS})
-
-  # If boost unit test library is linked dynamically, BOOST_TEST_DYN_LINK must be defined
-  string(REGEX MATCH ".a$" BOOST_STATIC_UNIT_TEST_LIB ${Boost_UNIT_TEST_FRAMEWORK_LIBRARY})
-  if (NOT BOOST_STATIC_UNIT_TEST_LIB)
-    set(TARGET_COMPILE_FLAGS "${TARGET_COMPILE_FLAGS} -DBOOST_TEST_DYN_LINK")
-  endif()
-  target_link_libraries(${NAME} ${Boost_UNIT_TEST_FRAMEWORK_LIBRARY})
-
-  # Tests need to link with SDL library without main.
-  set(SDL_LIBRARY_TEMP ${SDL_LIBRARY})
-  list(REMOVE_ITEM SDL_LIBRARY_TEMP ${SDLMAIN_LIBRARY})
-  target_link_libraries(${NAME} ${SDL_LIBRARY_TEMP})
-
-  _common_compile_tasks()
-
-  add_test(${NAME} ${NAME})
-  add_dependencies(wl_tests ${NAME})
-endfunction()
-
-# Checks a single 'SRC' file using Codecheck and writes a file named
-# codecheck_<shasum of input> if the codecheck did not yield anything. The
-# target for the codecheck will be added as a dependency to 'NAME' for debug
-# builds, but always for the target 'codecheck', so that make codecheck checks
-# all source code.
-function(run_codecheck NAME SRC)
-  get_filename_component(ABSOLUTE_SRC ${SRC} ABSOLUTE)
-
-  # If the file does not exist, it is probably auto-generated. In that case, it
-  # makes no sense to codecheck it.
-  if(EXISTS ${ABSOLUTE_SRC})
-    string(SHA1 CHECKSUM ${ABSOLUTE_SRC})
-
-    set(OUTPUT_FILE "${CMAKE_CURRENT_BINARY_DIR}/codecheck_${CHECKSUM}")
-    add_custom_command(
-      OUTPUT
-        ${OUTPUT_FILE}
-      COMMAND
-        ${CMAKE_COMMAND}
-        -DPYTHON_EXECUTABLE=${PYTHON_EXECUTABLE}
-        -DWL_SOURCE_CHECKER=${CMAKE_SOURCE_DIR}/cmake/codecheck/CodeCheck.py
-        -DSRC=${ABSOLUTE_SRC}
-        -DOUTPUT_FILE=${OUTPUT_FILE}
-        -DCMAKE_CURRENT_BINARY_DIR=${CMAKE_CURRENT_BINARY_DIR}
-        -P ${CMAKE_SOURCE_DIR}/cmake/codecheck/CodeCheck.cmake
-      DEPENDS ${ABSOLUTE_SRC}
-      COMMENT "Checking ${SRC} with CodeCheck"
-    )
-    add_custom_target(
-      see_if_codecheck_needs_to_run_${CHECKSUM}
-      DEPENDS ${OUTPUT_FILE}
-      COMMENT ""
-    )
-
-    add_dependencies(codecheck see_if_codecheck_needs_to_run_${CHECKSUM})
-
-    if(CMAKE_BUILD_TYPE STREQUAL Debug)
-      add_dependencies(${NAME} see_if_codecheck_needs_to_run_${CHECKSUM})
-    endif(CMAKE_BUILD_TYPE STREQUAL Debug)
-  endif(EXISTS ${ABSOLUTE_SRC})
-endfunction(run_codecheck)
-
 wl_library(build_info
   SRCS
     build_info.cc