widelands-dev team mailing list archive

[Holger Rapp <HolgerRapp@xxxxxxx>]

On 30.07.2014, at 21:06, Fòram na Gàidhlig <fios@xxxxxxxxxxxxxxxxxxx> wrote:

> 30/07/2014 18:31, sgrìobh Holger Rapp:
>> 
>> On 30.07.2014, at 11:46, Fòram na Gàidhlig <fios@xxxxxxxxxxxxxxxxxxx
>> <mailto:fios@xxxxxxxxxxxxxxxxxxx>> wrote:
>> 
>>> Since we have 1 central file now - maybe just mention that one on an
>>> appropriate Wiki page, so people will know it's there?
>> 
>> In my experience nobody reads the Wiki :). I think it is better to point
>> it out in code reviews and encourage people to start regression tests.
>> That process is actually documented in the developers docs:
>> 
>> https://wl.widelands.org/docs/wl/introduction/#regression-testing-infrastructure
> 
> regression_test.py isn't mentioned there, and searching the wiki for
> test, tests, or testing also does not turn up this page.
> 
> I expect that I am the one who broke the test and it would have been
> easiest to fix it right away while working on the code - had I known it
> was there to run ;)

I agree. It is my shortcoming for not pointing it out earlier (i.e. in code reviews). That said, feel free to add it on the Wiki or documentation where you think you would have been stumbling on it. Have you searched on the site for test before? I think it is unlikely that anybody else would have either. 

It is also not the end of the world that tests broke - that is what they are there for, to signalize change. Maybe a bug will surface while reworking them, maybe not.

Attachment: smime.p7s
Description: S/MIME cryptographic signature