widelands-dev team mailing list archive
-
widelands-dev team
-
Mailing list archive
-
Message #03185
Re: [Merge] lp:~widelands-dev/widelands/bug-768826 into lp:widelands
LGTM, except for a couple more nits. One functionality change:
- In the editor, remove the blank space between ( and the first coordinate
And two code style nits:
- add operator padding to (is_game)?25:5 (codecheck doesn't catch this case, but it should look like this: (is_game) ? 25 : 5)
- Properly align the closing parenthesis for dst.blit(. It should either be where it was, or at the end of the last parameter - I think the last option is preferred.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-768826/+merge/242544
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-768826.
References