widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

Can you please add some regression tests as well?

They should go in test/maps/lua_testsuite.wmf/scripting/flag.lua

You can run these tests directly without having to run the whole test suite:

./widelands --scenario=test/maps/lua_testsuite.wmf

I have also spotted a NOCOM comment in the diff - please grep to make sure you have resolved these, unless they contain a codereview question.

Once this is done, I'll have a closer look :)
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1380286/+merge/242975
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1380286 into lp:widelands.