widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/ai-enhancements into lp:widelands

To: mp+250207@xxxxxxxxxxxxxxxxxx
From: SirVer <SirVer@xxxxxx>
Date: Thu, 19 Feb 2015 07:10:38 -0000
In-reply-to: <20150218203530.8490.11619.launchpad@ackee.canonical.com>
Reply-to: mp+250207@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

> There was suggestion by SirVer to add a regression test for it, but I see that LUA api for control a ship movement is needed, so this would be separate job - making LUA interface to navigate the ship and prepare a test for this functionality.

there are other tests that control ships via UI scripting already. You could do that too (grep for 'click_on_ship' in tests/maps/expedition.wmf). 

otherwise lgtm.
-- 
https://code.launchpad.net/~widelands-dev/widelands/ai-enhancements/+merge/250207
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai-enhancements.

References

[Merge] lp:~widelands-dev/widelands/ai-enhancements into lp:widelands
From: TiborB, 2015-02-18