widelands-dev team mailing list archive

[Jens Beyer <Qcumber-some@xxxxxxxxxxxxx>]

Jens Beyer has proposed merging lp:~widelands-dev/widelands/bug1480928 into lp:widelands.

Requested reviews:
  Widelands Developers (widelands-dev)
Related bugs:
  Bug #1480928 in widelands: "Lumberjack animation glitches"
  https://bugs.launchpad.net/widelands/+bug/1480928

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug1480928/+merge/270540

Animation seems to loop to the first picture again.

Easy fix - remove 1ms of the animation ;-)


I believe it would not be good to remove the looping from animation in general. Other way would probably be tinkering with the fps, but I don't know if it takes fraction values like 10.001 or something.
-- 
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug1480928 into lp:widelands.

=== modified file 'world/immovables/trees/aspen/init.lua'
--- world/immovables/trees/aspen/init.lua	2015-08-13 18:30:36 +0000
+++ world/immovables/trees/aspen/init.lua	2015-09-09 14:18:22 +0000
@@ -93,7 +93,7 @@
          "seed=aspen_summer_sapling",
       },
       fall = {
-         "animate=falling 1200",
+         "animate=falling 1199",
          "transform=fallentree",
       },
    },

=== modified file 'world/immovables/trees/oak/init.lua'
--- world/immovables/trees/oak/init.lua	2015-08-13 18:30:36 +0000
+++ world/immovables/trees/oak/init.lua	2015-09-09 14:18:22 +0000
@@ -90,7 +90,7 @@
          "seed=oak_summer_sapling",
       },
       fall = {
-         "animate=falling 1200",
+         "animate=falling 1199",
          "transform=fallentree",
       },
    },