widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

Review: Needs Fixing



Diff comments:

> 
> === modified file 'utils/buildcat.py'
> --- utils/buildcat.py	2015-11-06 18:57:00 +0000
> +++ utils/buildcat.py	2015-11-27 17:43:13 +0000
> @@ -58,8 +58,9 @@
>          "../../world/*/*/*/*/*/*.lua",
>      ]),
>      ("tribes/tribes", [
> -        "../../tribes/scripting/starting_conditions/*/*.lua"
> +        "../../tribes/scripting/starting_conditions/*/*.lua" # TODO(GunChleoc): the starting conditions aren't being picked up.

there is a comma missing after this line. this will combine this and the next string into one runaway one.

>          "../../tribes/*.lua",
> +        "../../tribes/preload.lua", # TODO(GunChleoc): Why do I have to load both *.lua and preload.lua for this to work?

adding the comma above should solve that.

>          "../../tribes/*/init.lua",
>          "../../tribes/*/*/init.lua",
>          "../../tribes/*/*/*/init.lua",


-- 
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/278857
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/string-fixes.