widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

Review: Approve

You should probably use another branch name in the future. This one has all those fixed bugs attached.

One tiny nit, otherwise lgtm.

Diff comments:

> 
> === modified file 'src/ui_basic/progresswindow.cc'
> --- src/ui_basic/progresswindow.cc	2016-01-31 21:03:15 +0000
> +++ src/ui_basic/progresswindow.cc	2016-02-04 16:17:22 +0000
> @@ -92,6 +92,7 @@
>  }
>  
>  void ProgressWindow::step(const std::string & description) {
> +

remove empty line?

>  	RenderTarget & rt = *g_gr->get_render_target();
>  
>  	const uint32_t xres = g_gr->get_xres();


-- 
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/285088
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/string-fixes.