← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands-website/add_hints into lp:widelands-website

 

Review: Resubmit

Thanks for proofreading :-)

Some indentation is fixed and the exception for the KeyError was useless. The idea was to have a hint if something in wl_map_info and the resulting json file was changed. But if this is the case, the call to wl_map_info fails before the KeyError exception is triggered, so i removed this.

To the weird indentaion of *.py files: This is what pyformat does.

> Can ^(?P<map_slug>[-\w]+) be refactored into a variable?

This is a regular expression and the normal way Django searches for URLs to provide a specific view. But maybe i do not understand what you mean... Regular expressions are much complicated and i don't want to play around with this until i really know what i am doing.
-- 
https://code.launchpad.net/~widelands-dev/widelands-website/add_hints/+merge/285664
Your team Widelands Developers is subscribed to branch lp:widelands-website.


Follow ups

References