← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands-website/add_hints into lp:widelands-website

 

> Thanks for proofreading :-)
> 
> To the weird indentaion of *.py files: This is what pyformat does.

OK - manually fixing after pyformat doesn't make sense.


> > Can ^(?P<map_slug>[-\w]+) be refactored into a variable?
> 
> This is a regular expression and the normal way Django searches for URLs to
> provide a specific view. But maybe i do not understand what you mean...
> Regular expressions are much complicated and i don't want to play around with
> this until i really know what i am doing.

We have this string as a part of a bunch of regex and it gets repeated, so I was wondering if it made the code more readable to extract that part into a string variable.

-- 
https://code.launchpad.net/~widelands-dev/widelands-website/add_hints/+merge/285664
Your team Widelands Developers is subscribed to branch lp:widelands-website.


References