widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

> I am still missing some comments about the basic
> workings of this (very sepcial) window. and I have some questions:
> 
> * why is uint8_t as index, a plain unsigned int would not make a difference?

Old code. We actually think that using int is even better than unsigned int, because it prevents overflow errors.


> * why is there no visual response when adding the last view fails?

Because nobody has noticed or taken care of it. Maybe we should pop up a WLMessageBox?



> I cannot reproduce #1553699 directly, as the filesaveversion sha changed, uhm:
> 
> roaddata: road 455: [...watchwindow-fixes/src/economy/request.cc:172] request:
> [...watchwindow-fixes/src/logic/map_objects/tribes/requirements.cc:51]
> requirements:
> 
> UnhandledVersionError:
> 
> I must tray with some new game.

I guess the easiest way for testing now is to just merge this, so we have a higher chance of the error occurring if it still does. So, I'll mark the bug as "Fix Committed" after merging, and we can reopen the bug if it happens again.

-- 
https://code.launchpad.net/~widelands-dev/widelands/watchwindow-fixes/+merge/289573
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/watchwindow-fixes.