← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands-website/add_DISPLAY_to_update_help into lp:widelands-website

 

> > Running os.path.normpath(directory) should take care of any double slashes -
> > this is how I fixed up things during the last code review round. Looks like
> we
> > have missed a few :(
>  I think having paths with double slashes should be fixed where they are
> build. Failures like this one would otherwise be triggered again and again
> when one writes new code.

Agreed - ron the normpath ove it at the place that it is built if possible

> > Are you still having problems with the pdf?
> I have managed to fixed this too by renaming "media/wlhelp/network_graphs" and
> run
> 
> ./manage.py update_help_pdf
> 
> again. This time it was running through without problems.

Looking good :)


> So all should be fine now on the productive website. What remains is then to
> manage the automatic update of the help...

I don't think we really need an automatic update here - this data doesn't change very often. Maybe as a wishlist bug?

-- 
https://code.launchpad.net/~widelands-dev/widelands-website/add_DISPLAY_to_update_help/+merge/295756
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands-website/add_DISPLAY_to_update_help into lp:widelands-website.


Follow ups

References