← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands-website/auto_one_to_one_ractivating into lp:widelands-website

 

The @atomic decorator is only used with transactions, which depends on 

- the version of database
- the capability of the Database 
- table engine of the Database
- the settings of a database.

As far as i know we doesn't use transactions in our code and trust to the django default Autocommit mode (which is also default in MySql)

Nevertheless by reading through https://docs.djangoproject.com/en/1.8/topics/db/transactions/ i guess it is not bad to set this decorator. But i am no database specialist and my guess is maybe wrong.

I think we will never use transactions, so why should we (i) add this decorator if the consequences are unknown...

This Database stuff is really complicated... lets keep it as simple as it could be, imho.
-- 
https://code.launchpad.net/~widelands-dev/widelands-website/auto_one_to_one_ractivating/+merge/310813
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands-website/auto_one_to_one_ractivating into lp:widelands-website.


References