widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

Review: Approve

I cannot really comment on the AutoSingleRelatedObjectDescriptor - it seems to work around various non-backwards compatible changes in django overtime. For example this comment about caching and not returning the created objects sounds frightening....

Let's get it in and hope for the best. Sometimes hope is a strategy :)
 

Diff comments:

> 
> === modified file 'settings.py'
> --- settings.py	2016-10-29 07:00:53 +0000
> +++ settings.py	2016-11-15 08:03:51 +0000
> @@ -75,7 +76,7 @@
>      'django.contrib.staticfiles',
>      'django.contrib.sites',
>      'django.contrib.humanize',
> -    #'django_comments',

ups.. did that slip in?

> +    'django_comments',
>      'nocaptcha_recaptcha',
>      # Thirdparty apps, but need preload
>      'tracking', # included as wlapp


-- 
https://code.launchpad.net/~widelands-dev/widelands-website/auto_one_to_one_ractivating/+merge/310813
Your team Widelands Developers is subscribed to branch lp:widelands-website.