widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

About the window handling for economy merge, as I see it, we have 3 options:

1. Have the boolean in Economy like in the current implementation.

2. InteractiveBase::unique_windows(), with InteractiveBase subscribing to the note

3. InteractiveBase::unique_windows(), with EconomyWindow reading the window state from InteractiveBase

I think 2. is the most ugly option, so I'll look into 3.


Regarding the renaming, we will have to do this in an identical fashion for NoteShipWindow and NoteBuildingWindow (this one is waiting in a new branch). Currently, we have for ships:

	NoteShipMessage,
	NoteShipWindow,

renaming the second one of those to "NoteShip" would make the naming not orthogonal - how about "Note***Changed"? It would make it less clear what the note is used for though.
-- 
https://code.launchpad.net/~widelands-dev/widelands/notifications_economy_window/+merge/311572
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/notifications_economy_window.