widelands-dev team mailing list archive
-
widelands-dev team
-
Mailing list archive
-
Message #08908
Re: [Merge] lp:~widelands-dev/widelands/notifications_economy_window into lp:widelands
3 sounds alright to me if you hand in the UniqueWindowHandler, not the whole InteractiveBase class. I think that should work alright.
The two ship messages could probably be folded into one anyways... right now, the first one is kLost, kGained (I guess a new ship/one destroyed) and kWaitingForCommand. And the second one is 'kClose' and 'kRefresh'. kClose is only sent when the ship is destroyed, so there seems to be overlap already. And kRefresh can be folded as kStateChanged which makes it clear enough that this is for UI and other observers interested in this IMHO.
--
https://code.launchpad.net/~widelands-dev/widelands/notifications_economy_window/+merge/311572
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/notifications_economy_window.
References