widelands-dev team mailing list archive

[Hans Joachim Desserud <launchpad@xxxxxxxxxxxx>]

Sure, can fix :)

Though (see my comment below), I still wonder what happened to GCC 4.7. If the required minimum version has been increased, then CMakeLists.txt and possibly other documentation should be updated alongside.

Diff comments:

> === modified file '.travis.yml'
> --- .travis.yml	2017-02-11 10:48:12 +0000
> +++ .travis.yml	2017-02-12 09:14:39 +0000
> @@ -20,30 +20,26 @@
>       - compiler: clang
>         env: CLANG_VERSION="3.5" BUILD_TYPE="Debug"
>       - compiler: clang
> -       env: CLANG_VERSION="3.8" BUILD_TYPE="Debug"
> -     - compiler: clang
>         env: CLANG_VERSION="3.9" BUILD_TYPE="Debug"
>       - compiler: clang
> +       env: CLANG_VERSION="4.0" BUILD_TYPE="Debug"
> +     - compiler: clang
>         env: CLANG_VERSION="3.4" BUILD_TYPE="Release"
>       - compiler: clang
>         env: CLANG_VERSION="3.5" BUILD_TYPE="Release"
>       - compiler: clang
> -       env: CLANG_VERSION="3.8" BUILD_TYPE="Release"
> -     - compiler: clang
>         env: CLANG_VERSION="3.9" BUILD_TYPE="Release"
> +     - compiler: clang
> +       env: CLANG_VERSION="4.0" BUILD_TYPE="Release"
>       - compiler: gcc
>         env: GCC_VERSION="4.8" BUILD_TYPE="Debug"

Hm, this doesn't add up after I merged.

Was GCC 4.7 removed intentionally? Because CMakeLists.txt still claims is the minimum required version?

>       - compiler: gcc
> -       env: GCC_VERSION="4.9" BUILD_TYPE="Debug"
> -     - compiler: gcc
>         env: GCC_VERSION="5" BUILD_TYPE="Debug"
>       - compiler: gcc
>         env: GCC_VERSION="6" BUILD_TYPE="Debug"
>       - compiler: gcc
>         env: GCC_VERSION="4.8" BUILD_TYPE="Release"
>       - compiler: gcc
> -       env: GCC_VERSION="4.9" BUILD_TYPE="Release"
> -     - compiler: gcc
>         env: GCC_VERSION="5" BUILD_TYPE="Release"
>       - compiler: gcc
>         env: GCC_VERSION="6" BUILD_TYPE="Release"


-- 
https://code.launchpad.net/~hjd/widelands/additional-compilers/+merge/316258
Your team Widelands Developers is requested to review the proposed merge of lp:~hjd/widelands/additional-compilers into lp:widelands.