widelands-dev team mailing list archive

[Hans Joachim Desserud <launchpad@xxxxxxxxxxxx>]

Hans Joachim Desserud has proposed merging lp:~hjd/widelands/additional-compilers into lp:widelands.

Requested reviews:
  Widelands Developers (widelands-dev)

For more details, see:
https://code.launchpad.net/~hjd/widelands/additional-compilers/+merge/316258

Add clang 4.0 and GCC 7 to the compiler matrix. The latter one should be available from the ubuntu-toolchain PPA at least.

Note that both of these are soon-to-be-released versions, so I don't know if we want to merge them right away or wait for official releases. I'd like to see if there are any obvious issues we need to look into before then though, so this review is mainly to see what bunnybot reports.


(Somewhat) related question, I looked at the .travis.sh script and wonder why it builds against SDL2-snapshots?
-- 
Your team Widelands Developers is requested to review the proposed merge of lp:~hjd/widelands/additional-compilers into lp:widelands.

=== modified file '.travis.yml'
--- .travis.yml	2016-10-09 09:36:13 +0000
+++ .travis.yml	2017-02-02 18:25:22 +0000
@@ -28,6 +28,8 @@
      - compiler: clang
        env: CLANG_VERSION="3.9" BUILD_TYPE="Debug"
      - compiler: clang
+       env: CLANG_VERSION="4.0" BUILD_TYPE="Debug"
+     - compiler: clang
        env: CLANG_VERSION="3.4" BUILD_TYPE="Release"
      - compiler: clang
        env: CLANG_VERSION="3.5" BUILD_TYPE="Release"
@@ -39,6 +41,8 @@
        env: CLANG_VERSION="3.8" BUILD_TYPE="Release"
      - compiler: clang
        env: CLANG_VERSION="3.9" BUILD_TYPE="Release"
+     - compiler: clang
+       env: CLANG_VERSION="4.0" BUILD_TYPE="Release"
      - compiler: gcc
        env: GCC_VERSION="4.7" BUILD_TYPE="Debug"
      - compiler: gcc
@@ -50,6 +54,8 @@
      - compiler: gcc
        env: GCC_VERSION="6" BUILD_TYPE="Debug"
      - compiler: gcc
+       env: GCC_VERSION="7" BUILD_TYPE="Debug"
+     - compiler: gcc
        env: GCC_VERSION="4.7" BUILD_TYPE="Release"
      - compiler: gcc
        env: GCC_VERSION="4.8" BUILD_TYPE="Release"
@@ -59,3 +65,5 @@
        env: GCC_VERSION="5" BUILD_TYPE="Release"
      - compiler: gcc
        env: GCC_VERSION="6" BUILD_TYPE="Release"
+     - compiler: gcc
+       env: GCC_VERSION="7" BUILD_TYPE="Release"