← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/bug-1675179-lua-hide-fields into lp:widelands

 

Review: Approve

- It only affects the current player, other players' and critters' states shouldn't care about what I see

afaik the only thing that does look at your current vision is the scout. And if you have a different vision table than some other host on the game around the area of the scout, the scout will make different decisions and desync the game. 

I think this branch does not change the dangerous around this (as you said), but the feature could be used to potentially desync multiplayer scenarios if some reveal code only runs on one of the networked machines. I think this can be ignored for now. 


lgtm. 

@bunnybot merge
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1675179-lua-hide-fields/+merge/320981
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1675179-lua-hide-fields.


References