widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

Review: Approve code

Good change!

One suggestion to improve the code: how about we disallow Vector2i() (by making the default constructor deleted) and instead have a static function Vector2i::Zero() that returns Vector2i(0, 0). It would make the call sites slightly easier to read. 

otherwise code lgtm. I did not test.
-- 
https://code.launchpad.net/~widelands-dev/widelands/rendertarget_ints/+merge/322996
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/rendertarget_ints.