widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

Thanks for the review :)

The crash looks unfamiliar, I'll have to look into this.


> Is there a reason that Bob::calc_drawpos() (and derived methods) are still returning floats? 

Yes, these are there for the zoom function, map elements can now end up not being positioned pixel perfect.


> UI::correct_for_align() and UI::center_vertically() are somehow related from what they are doing but are offering quite different interfaces.

Not really. center_vertically() is omitting the align parameter, because align is always centered here.


> correct_for_align(kCenter) is called but correct_for_align(kLeft) is omitted.

I'll go over these again when we do the final RTL GUI switching code.
-- 
https://code.launchpad.net/~widelands-dev/widelands/rendertarget_ints/+merge/322996
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/rendertarget_ints into lp:widelands.