← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/net-internetgaming-ipv6 into lp:widelands

 

2 nits/ideas:

   if (packet.string() == "1")

What does the 1 mean here?

   std::pair<NetAddress, NetAddress>

Make this a struct with 2 members called ip_6_addr, ip_4_addr, with ip_6_addr potentially empty?
-- 
https://code.launchpad.net/~widelands-dev/widelands/net-internetgaming-ipv6/+merge/326027
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/net-internetgaming-ipv6 into lp:widelands.


References