widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

Review: Approve

more stuff can be removed, see inline comment.

Diff comments:

> 
> === modified file 'src/logic/editor_game_base.cc'
> --- src/logic/editor_game_base.cc	2017-02-28 12:59:39 +0000
> +++ src/logic/editor_game_base.cc	2017-06-23 17:42:19 +0000
> @@ -419,31 +419,6 @@
>  	return lasttrackserial_;
>  }
>  
> -/*
> -===============
> -Retrieve a previously stored pointer using the serial number.
> -Returns 0 if the pointer has been removed.
> -===============
> -*/
> -void* EditorGameBase::get_trackpointer(uint32_t const serial) {
> -	std::map<uint32_t, void*>::iterator it = trackpointers_.find(serial);

add_trackpointer() is also not used in the codebase. Also not trackkpointers_ and last_track_serial_ members. Remove them all?

> -
> -	if (it != trackpointers_.end())
> -		return it->second;
> -
> -	return nullptr;
> -}
> -
> -/*
> -===============
> -Remove the registered track pointer. Subsequent calls to get_trackpointer()
> -using this serial number will return 0.
> -===============
> -*/
> -void EditorGameBase::remove_trackpointer(uint32_t serial) {
> -	trackpointers_.erase(serial);
> -}
> -
>  /**
>   * Cleanup for load
>   *


-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-986611-cppcheck-unused/+merge/326236
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-986611-cppcheck-unused.