widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

Review: Needs Fixing



Diff comments:

> 
> === modified file 'src/graphic/text/rt_render.cc'
> --- src/graphic/text/rt_render.cc	2017-06-01 08:52:15 +0000
> +++ src/graphic/text/rt_render.cc	2017-06-24 11:37:18 +0000
> @@ -969,7 +969,7 @@
>  public:
>  	TagHandler(Tag& tag,
>  	           FontCache& fc,
> -	           NodeStyle ns,

This changes semantics and is almost certainly wrong (also a few times below). Either 
NodeStyle -> const NodeStyle&  or keep passing by value.

> +	           NodeStyle& ns,
>  	           ImageCache* image_cache,
>  	           RendererStyle& renderer_style,
>  	           const UI::FontSets& fontsets)


-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-986611-cppcheck-pass-by-reference/+merge/326257
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-986611-cppcheck-pass-by-reference.