widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/dynamic_tribe_loading into lp:widelands

To: mp+329198@xxxxxxxxxxxxxxxxxx
From: GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 03 Nov 2017 18:50:03 -0000
In-reply-to: <150297060347.10535.14879531152105073192.launchpad@ackee.canonical.com>
Reply-to: mp+329198@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Resubmit

This should be ready now.

I added the remaining comments as NOCOM to the code for easier review and addressed all the rest. I have answered in the code.

For full testing, take the datadir from

https://code.launchpad.net/~widelands-dev/widelands/dynamic_tribe_loading_datadir

And start Empire Scenario 4.
-- 
https://code.launchpad.net/~widelands-dev/widelands/dynamic_tribe_loading/+merge/329198
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/dynamic_tribe_loading.

References

[Merge] lp:~widelands-dev/widelands/dynamic_tribe_loading into lp:widelands
From: GunChleoc, 2017-08-17