← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~flegu/widelands/r8481-renderedtext-memory-leaks into lp:widelands

 

Thanks for the fix!

Looks good to me - can you please replace UI::RenderedText::Shared with std::shared_ptr<UI::RenderedText> and get rid of the new using statement? I think that would make the code easier to read.
-- 
https://code.launchpad.net/~flegu/widelands/r8481-renderedtext-memory-leaks/+merge/333578
Your team Widelands Developers is requested to review the proposed merge of lp:~flegu/widelands/r8481-renderedtext-memory-leaks into lp:widelands.


Follow ups

References