widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~flegu/widelands/r8481-renderedtext-memory-leaks into lp:widelands

To: mp+333578@xxxxxxxxxxxxxxxxxx
From: Jukka Pakarinen <flegmaatikko@xxxxxxxxx>
Date: Sat, 11 Nov 2017 16:34:59 -0000
In-reply-to: <151041537141.7831.12321827212231605639.codereview@soybean.canonical.com>
Reply-to: mp+333578@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

> Thanks for the fix!
> 
> Looks good to me - can you please replace UI::RenderedText::Shared with
> std::shared_ptr<UI::RenderedText> and get rid of the new using statement? I
> think that would make the code easier to read.

Sure, I can do that.
-- 
https://code.launchpad.net/~flegu/widelands/r8481-renderedtext-memory-leaks/+merge/333578
Your team Widelands Developers is requested to review the proposed merge of lp:~flegu/widelands/r8481-renderedtext-memory-leaks into lp:widelands.

References

Re: [Merge] lp:~flegu/widelands/r8481-renderedtext-memory-leaks into lp:widelands
From: GunChleoc, 2017-11-11