widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/add_custom_building into lp:widelands

To: mp+334062@xxxxxxxxxxxxxxxxxx
From: hessenfarmer <stephan-lutz@xxxxxx>
Date: Sat, 25 Nov 2017 15:41:14 -0000
In-reply-to: <151128458685.22423.12450781651835682995.launchpad@ackee.canonical.com>
Reply-to: mp+334062@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Did a complete test of the empire 4 scenario ans some other test regarding the trainingsites_max_percent value. Also had a look to the code. The branch now handles the value in a way that it will not crash anymore. The scenario ran through without any observations. So I would say the branch is ready for merging.
However I am not very happy with the algorithm handling the value and the definition of these values.
But i will open a new bug for this.
-- 
https://code.launchpad.net/~widelands-dev/widelands/add_custom_building/+merge/334062
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/add_custom_building.

References

[Merge] lp:~widelands-dev/widelands/add_custom_building into lp:widelands
From: GunChleoc, 2017-11-21