widelands-dev team mailing list archive

[Hans Joachim Desserud <launchpad@xxxxxxxxxxxx>]

Hans Joachim Desserud has proposed merging lp:~hjd/widelands/asan-off-deb-package into lp:widelands.

Requested reviews:
  Widelands Developers (widelands-dev)
Related bugs:
  Bug #1734659 in widelands: "Switch off ASAN in ubuntu packaging"
  https://bugs.launchpad.net/widelands/+bug/1734659

For more details, see:
https://code.launchpad.net/~hjd/widelands/asan-off-deb-package/+merge/334321

Disable ASAN when building the Debian package.

Started a test run in my PPA, let's see how this works https://code.launchpad.net/~hjd/+recipe/widelands-test 
-- 
Your team Widelands Developers is requested to review the proposed merge of lp:~hjd/widelands/asan-off-deb-package into lp:widelands.

=== modified file 'debian/changelog'
--- debian/changelog	2017-08-29 16:03:34 +0000
+++ debian/changelog	2017-11-27 17:39:01 +0000
@@ -8,6 +8,7 @@
       - Also dropped version-specific glew alternative.
         1.6 doesn't seem to be around anymore and the versionless one
         seems to work across the different distro releases we build for
+  * Build with ASAN disabled since parts of the code atm breaks
   * Merged Debian packaging of Widelands 1:19+repack-4. Remaining changes:
     - Revert debhelper/compat level to 9. (Ubuntu 14.04 doesn't have debhelper 10.)
     - Disabled all Debian-patches since applying them might cause conflicts as

=== modified file 'debian/rules'
--- debian/rules	2017-08-26 09:24:28 +0000
+++ debian/rules	2017-11-27 17:39:01 +0000
@@ -18,6 +18,7 @@
 		-DWL_INSTALL_DATADIR=/usr/share/games/widelands/data \
 		-DWL_INSTALL_PREFIX=/usr \
 		-DOPTION_USE_GLBINDING:BOOL=OFF \
+		-DOPTION_ASAN=OFF \
 		-DCMAKE_BUILD_TYPE=Release
 
 override_dh_auto_install: