← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/fix_invalid_memory_access_on_dismantle into lp:widelands

 

Review: Approve review

Yep, this is basically my fix, will not compile or test this one, though.

See http://bazaar.launchpad.net/~widelands-dev/widelands/bug_1730204-crash/revision/8496

I added this code as well:

void BuildingWindow::die() {
    assert(!is_dying_); // Building Window must not die() twice

is this reasonable?

-- 
https://code.launchpad.net/~widelands-dev/widelands/fix_invalid_memory_access_on_dismantle/+merge/334428
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fix_invalid_memory_access_on_dismantle.


References