widelands-dev team mailing list archive

[Klaus Halfmann <klaus.halfmann@xxxxxxxx>]

Mhh ravis has only this, unrelated Problem:

WARNING: The following packages cannot be authenticated!

  gcc-7-base libgcc1 libstdc++6 libasan4 libatomic1 libcc1-0 libcilkrts5
  libgomp1 libisl15 libitm1 liblsan0 libmpfr4 libmpx2 libquadmath0 libtsan0
  libubsan0 cpp-7 libgcc-7-dev gcc-7 libstdc++-7-dev g++-7

E: There were unauthenticated packages and -y was used without --allow-unauthenticated

Lets check your Fleißarbeit:

what is the problem with constructs like this one?
- const auto read_terrains = [this, &table, &world](
+ const auto read_terrains = [&table, &world](

nitpicking : why did you drop "virtual" while adding "overrride"?

Otherwise all fine, I let the compler run trough it.
Better even the original OSX compiler, just for completeness....
-- 
https://code.launchpad.net/~widelands-dev/widelands/clang5-warnings-destructors/+merge/334286
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/clang5-warnings-destructors into lp:widelands.