← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/clang5-warnings-destructors into lp:widelands

 

Review: Approve compile, small test

compiled fien with clang 5.0 less noise, fine.

with OSX clang 
Apple LLVM version 9.0.0 (clang-900.0.38)
Target: x86_64-apple-darwin17.2.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
I now get 

clang5-warnings-destructors/src/third_party/gettext/gettext.h:29:34: 
warning: unknown warning group'-Wzero-as-null-pointer-constant', ignored [-Wunknown-warning-option]

well :-)

it even compiled with ASAN!, which I did not expect

And got an ASAN cars in:

SUMMARY: AddressSanitizer: heap-use-after-free string:1213 in GameMainMenuSaveGame::entry_selected()


-- 
https://code.launchpad.net/~widelands-dev/widelands/clang5-warnings-destructors/+merge/334286
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/clang5-warnings-destructors.


References