widelands-dev team mailing list archive

[Notabilis <notabilis27@xxxxxx>]

With such a great commit message you can give me as much NOCOMs as you want. ;)

4) I implemented your suggestion, but I am not completely happy with it. The move constructors are gone but there are still a few of the evil std::move in the code. Decide for yourself, I guess. I could get rid of them by storing raw pointers in the received_ queue but I am not such a fan of the idea.

5) I made the NOCOM regarding the duplicated code to a TODO note. Pulling out a method should be done but I don't know where to put it right now. I guess some place will present itself when the feature is added for real.

NOCOMs are all done (for now...).
-- 
https://code.launchpad.net/~widelands-dev/widelands/net-relay/+merge/332386
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/net-relay into lp:widelands.