widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

4) I disagree. I think it looks wonderful! You only need std::move() to signalize that you move the front() of your queue and leave an empty vector - and without it, the code would read like a copy at this site. So the move adds readability. All in all the code now looks like I would expect it to.

5) Pull the function to somewhere, it doesn't matter much. Either in the one of the units where it is used and include the header from the other. Or one that is used by both. Reducing duplicated code is more important than finding the right place for the function IMHO. Please, for me? Pretty please?



-- 
https://code.launchpad.net/~widelands-dev/widelands/net-relay/+merge/332386
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/net-relay into lp:widelands.