← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/clang5-warnings-destructors into lp:widelands

 

Review: Approve test

I actually played this verson (wit a merge to trunk) during the tournament.
So this can go in. In can live with extra warnings for X-Code. Eventually
Ill adress them in some other branch.

Using 
> #ifndef __APPLE__
> #endif
will not Help as ther are 
a) to many such places
b) its the compile not the OS.

I will do another review and compile session,
but for me it can go in as is.
-- 
https://code.launchpad.net/~widelands-dev/widelands/clang5-warnings-destructors/+merge/334286
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/clang5-warnings-destructors.


References