widelands-dev team mailing list archive

[Klaus Halfmann <klaus.halfmann@xxxxxxxx>]

Review: Approve review

Just one question inline.

@bunnybot merge

Diff comments:

> 
> === modified file 'src/ai/defaultai.cc'
> --- src/ai/defaultai.cc	2017-11-26 17:43:25 +0000
> +++ src/ai/defaultai.cc	2017-12-02 11:52:29 +0000
> @@ -450,13 +450,13 @@
>  				};
>  				if (!basic_economy_established) {
>  					assert(!persistent_data->remaining_basic_buildings.empty());
> -					log("%2d: Basic economy not achieved, %lu building(s) missing, f.e.: %s\n",
> +					log("%2d: Basic economy not achieved, %" PRIuS " building(s) missing, f.e.: %s\n",

What kind of format ist that %" PRIuS" ?

>  					    player_number(), persistent_data->remaining_basic_buildings.size(),
>  					    get_building_observer(persistent_data->remaining_basic_buildings.begin()->first)
>  					       .name);
>  				}
>  				if (!enemy_warehouses.empty())
> -					log("Conquered warehouses: %d / %lu\n", conquered_wh, enemy_warehouses.size());
> +					log("Conquered warehouses: %d / %" PRIuS "\n", conquered_wh, enemy_warehouses.size());
>  				management_data.review(
>  				   gametime, player_number(), player_statistics.get_player_land(player_number()),
>  				   player_statistics.get_enemies_max_land(),


-- 
https://code.launchpad.net/~widelands-dev/widelands/clang5-warnings-destructors/+merge/334286
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/clang5-warnings-destructors.