widelands-dev team mailing list archive

[hessenfarmer <stephan-lutz@xxxxxx>]

Agreed.
I just found another two or three indentation issues in the diffs here on launchpad, which seem to be caused by pressing "Enter" in Notepad++. Sorry for that.
The reason for using Notepad++ is that with the additional Lua plugin, I can check my code for syntax errors which caused me a lot of pain before using this. Do you know whether there is a Geany version for Windows? If yes I would give it a try.

So the way forward now is you complete the code review. Afterwards we playtest, and then we are finished.
Just for your information. There is still one thing in the code I am not completely satisfied with. It is the part how to determine Whether the chaos in the road network has been solved. I have been thinking about this after I got a comment in the forum by Steven de Herdt. But I haven't found a solution yet. Currently I am only checking whether there are no loose ends in the network ( this means every flag has at least 2 roads or a building attached to it).
If you have any solution to determine the absence of chaos in the network I would really appreciate this and I would like to incorporate this before merging.
Things I thought about so far are determine the absence of "stars" (one road in every possible direction)in the network, but they might make sense in special cases so just allow one of them for example. Or count the total number of roads and check if that is below a reasonable number. But if you Build new buildings and roads before clearing the mess this would never trigger.

Thanks for the support 
-- 
https://code.launchpad.net/~widelands-dev/widelands/Mission4/+merge/334279
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/Mission4.