← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/frisians_string_fixes into lp:widelands

 

Looks good to me, one diff comment

Diff comments:

> === modified file 'data/campaigns/fri01.wmf/scripting/texts.lua'
> --- data/campaigns/fri01.wmf/scripting/texts.lua	2018-03-11 15:55:43 +0000
> +++ data/campaigns/fri01.wmf/scripting/texts.lua	2018-04-05 06:03:52 +0000
> @@ -312,7 +312,7 @@
>        _([[We are recruiting soldiers easily enough, but they are fairly weak. We must train our soldiers if they are to beat the enemy.]])
>         .. paragraphdivider() ..
>        -- TRANSLATORS: Reebaud – train soldiers 1
> -      _([[Soldiers are trained in basic attack, health and defense by a small training camp. They can learn the finer points in a large training arena.]])),
> +      _([[Soldiers are trained in basic attack, health and defense by a training camp. They can learn the finer points in a large training arena.]])),

Better remove the "large" from the training arena as well for consistency

>  }
>  training_2 = {
>     title =_ "Training Soldiers",


-- 
https://code.launchpad.net/~widelands-dev/widelands/frisians_string_fixes/+merge/342702
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/frisians_string_fixes into lp:widelands.


References