widelands-dev team mailing list archive

[Klaus Halfmann <klaus.halfmann@xxxxxxxx>]

Review: Approve compile, revied, debug for coverage, testplay

I testplayed this now on a seafaring Map:
 * I was unable to reach the following lies of code:
  * BuildingStatisticsMenu::foreign_tribe_building_is_valid()
    ...
    if (descr.type() == MapObjectType::CONSTRUCTIONSITE ||
	descr.type() == MapObjectType::DISMANTLESITE) {
	return false;
    // I think this can never be reached I can not build a forign building
    // A dismantled site cannot be reached 
  *  BuildingStatisticsMenu::reset() 
     ...
     if (building_buttons_[current_building_type_] != nullptr) {
	set_current_building_type(current_building_type_); // no idea what this shall be
     } else {
 * I found that some missing soldiers Arrows where incorrect for a foreign military building.

 * I played on a lot of different resolutions

Despite these Issues this can go in:

@bunnybot merge
-- 
https://code.launchpad.net/~widelands-dev/widelands/smaller_building_statistics/+merge/342828
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/smaller_building_statistics.