← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/productivity-string-fixes into lp:widelands

 

ok understood. But shouldn't the # be removed if there is a helptext defined? see inline comment

Diff comments:

> 
> === modified file 'data/tribes/buildings/productionsites/frisians/blacksmithy/helptexts.lua'
> --- data/tribes/buildings/productionsites/frisians/blacksmithy/helptexts.lua	2018-02-17 15:41:29 +0000
> +++ data/tribes/buildings/productionsites/frisians/blacksmithy/helptexts.lua	2018-04-28 06:28:06 +0000
> @@ -20,5 +20,5 @@
>  
>  function building_helptext_performance()
>     -- TRANSLATORS#: Performance helptext for a building
> -   return pgettext("frisians_building", "The blacksmith needs %s to produce one tool."):bformat(ngettext("%d second", "%d seconds", 67):bformat(67))

shouldn't the # sign after translators be removed as there is a helptext to translate?

> +   return pgettext("frisians_building", "The blacksmith needs %s on average to produce one tool."):bformat(ngettext("%d second", "%d seconds", 67):bformat(67))
>  end


-- 
https://code.launchpad.net/~widelands-dev/widelands/productivity-string-fixes/+merge/344796
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/productivity-string-fixes into lp:widelands.


Follow ups

References